refactor(analytics): conditionally load plausible based on domain presence #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
yhabib
changed the title
yhabib
changed the title
mstrasinskis
approved these changes
Feb 20, 2025
…he behaviour of the analytics
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
#6458) # Motivation We want to only load Plausible for `mainnet`, `beta` and `app` networks. # Changes - Moved Plausible test domain from the default to the app and beta section in config.json. - Ran `./scripts/nns-dapp/test-config --update` but no changes were generated. # Tests - Ran config scripts and observed: - `DFX_NETWORK=mainnet ./config.sh` -> `VITE_PLAUSIBLE_DOMAIN=nns.ic0.app` - `DFX_NETWORK=beta ./config.sh` -> `VITE_PLAUSIBLE_DOMAIN=test.nns.ic0.app` - `DFX_NETWORK=app ./config.sh` -> `VITE_PLAUSIBLE_DOMAIN=test.nns.ic0.app` - `DFX_NETWORK=local ./config.sh` -> `VITE_PLAUSIBLE_DOMAIN=` # Todos - [ ] Add entry to changelog (if necessary). Not necessary Prev. PR: #6459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we have confirmed the tool works, we can remove its configuration from the devenv and e2e environments. This way, we will only load it for the following networks:
Changes
PLAUSIBLE_DOMAINto empty string.Tests
domainproperty.Todos
Not necessary
Next PR: #6458