Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): install CMC in Orbit local deployment #465

Merged
merged 5 commits into from
Dec 18, 2024
Merged

fix(ci): install CMC in Orbit local deployment #465

merged 5 commits into from
Dec 18, 2024

Conversation

mraszyk
Copy link
Collaborator

@mraszyk mraszyk commented Dec 18, 2024

This PR installs CMC (proposal) in Orbit local deployments since CMC is required to create canisters (stations and external canisters). Additionally, this PR:

  • updates README to use PocketIC as the local IC backend (to retrieve its topology at an HTTP endpoint not served by the replica) and stop it using dfx stop rather than by CTRL^C (due to an issue in dfx)
  • updates dfx version (to include recent PocketIC serving its topology at an HTTP endpoint)

@mraszyk mraszyk changed the title fix: install CMC in Orbit local deployment fix(ci): install CMC in Orbit local deployment Dec 18, 2024
@mraszyk mraszyk marked this pull request as ready for review December 18, 2024 12:51
@mraszyk mraszyk requested a review from a team as a code owner December 18, 2024 12:51
jedna
jedna approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jedna jedna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works. Thanks!

@mraszyk mraszyk merged commit 7a2735d into main Dec 18, 2024
24 checks passed
@mraszyk mraszyk deleted the mraszyk/local-cmc branch December 18, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedna jedna jedna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraszyk @jedna