Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify log message when deploying to playground #4102

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

raymondk
Copy link
Contributor

@raymondk raymondk commented Feb 7, 2025

Description

When deploying to the playground we cannot verify the wasm hash because the playground may change the wasm before deploying. Clarify the message and show it only in verbose mode.

Fixes # SDK-1898

How Has This Been Tested?

❯ ddfx deploy --playground
WARN: Canister 'hello_backend' has timed out.
Deploying all canisters.
Reserving canisters in playground...
Reserved canister 'hello_backend' with id 7gngh-jqaaa-aaaab-qacvq-cai with the playground.
Building canisters...
Installing canisters...
Installing code for canister hello_backend, with canister ID 7gngh-jqaaa-aaaab-qacvq-cai
Deployed canisters.
URLs:
  Backend canister via Candid interface:
    hello_backend: https://a4gq6-oaaaa-aaaab-qaa4q-cai.raw.icp0.io/?id=7gngh-jqaaa-aaaab-qacvq-cai
❯ ddfx deploy --playground --verbose
Deploying all canisters.
All canisters have already been created.
Building canisters...
Installing canisters...
Previously installed module hash: Some("725f9a285847835b0789d7f72ce5d606299328644fa97902da54ca492d9978c8")
Upgrading code for canister hello_backend, with canister ID 7gngh-jqaaa-aaaab-qacvq-cai
New wasm module hash: e655e60848af7f9bc8cce486526f75846e8623d09214efbe489ba5f20e067f34
Module hash verification is skipped for playground deployments.
Deployed canisters.
URLs:
  Backend canister via Candid interface:
    hello_backend: https://a4gq6-oaaaa-aaaab-qaa4q-cai.raw.icp0.io/?id=7gngh-jqaaa-aaaab-qacvq-cai

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@raymondk raymondk requested a review from a team as a code owner February 7, 2025 02:41
@raymondk raymondk merged commit 697d336 into master Feb 7, 2025
298 checks passed
@raymondk raymondk deleted the raymond/sdk-1898 branch February 7, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants