Skip to content

Commit

Permalink
- refactor json gamefiles and remove duplicate keys
Browse files Browse the repository at this point in the history
- update CMakePresets.json
  • Loading branch information
dgcor committed Feb 10, 2025
1 parent 461dcc7 commit 7148a2a
Show file tree
Hide file tree
Showing 36 changed files with 116 additions and 113 deletions.
4 changes: 2 additions & 2 deletions DGEngine.core/src/Game/BaseAnimation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,6 @@ bool BaseAnimation::updateTexture(CompositeSprite& sprite, bool& absoluteOffset)

bool BaseAnimation::updateTexture(CompositeSprite& sprite) const
{
bool absoluteoffet;
return updateTexture(sprite, absoluteoffet);
bool absoluteOffset;
return updateTexture(sprite, absoluteOffset);
}
4 changes: 3 additions & 1 deletion DGEngine.core/src/Parser/Game/ParseGame.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "Parser/Utils/ParseUtils.h"
#include "ParseSaveDir.h"
#include "Utils/StringHash.h"
#include "Utils/Utils.h"

namespace Parser
{
Expand Down Expand Up @@ -98,7 +99,8 @@ namespace Parser
}
for (const auto& it : std::ranges::subrange(elem.MemberBegin(), elem.MemberEnd()))
{
parseGameElem(game, str2int16(it.name.GetStringView()), it.value);
auto [name, _] = Utils::splitStringIn2(it.name.GetStringView(), '.');
parseGameElem(game, str2int16(name), it.value);
}
}
}
3 changes: 2 additions & 1 deletion DGEngine.core/src/Parser/ParseFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ namespace Parser
ReplaceVars replaceVars = replaceVars_;
for (auto& it : std::ranges::subrange(doc.MemberBegin(), doc.MemberEnd()))
{
parseDocumentElemHelper(game, str2int16(it.name.GetStringView()),
auto [name, _] = Utils::splitStringIn2(it.name.GetStringView(), '.');
parseDocumentElemHelper(game, str2int16(name),
it.value, replaceVars, doc.GetAllocator());
}
}
Expand Down
2 changes: 1 addition & 1 deletion DGEngine.core/src/Parser/Utils/ParseUtilsKey.h
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ namespace Parser
}

sf::PrimitiveType getPrimitiveTypeKey(const rapidjson::Value& elem,
const std::string_view key, sf::PrimitiveType val = sf::PrimitiveType::TrianglesStrip);
const std::string_view key, sf::PrimitiveType val = sf::PrimitiveType::TriangleStrip);

// returns null JSON value if key doesn't exist.
// returns query[key] JSON value if query fails.
Expand Down
2 changes: 1 addition & 1 deletion DGEngine.core/src/Parser/Utils/ParseUtilsVal.h
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ namespace Parser
}

sf::PrimitiveType getPrimitiveTypeVal(const rapidjson::Value& elem,
sf::PrimitiveType val = sf::PrimitiveType::TrianglesStrip);
sf::PrimitiveType val = sf::PrimitiveType::TriangleStrip);

Number32 getMinMaxNumber32Val(const rapidjson::Value& elem);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ void BitmapFontTexturePack::calculateCharSizes(const sf::Image& img, int rows, i
{
charRects['\t'].width = cellW * 2;
}
else if (space > 0)
else if (tab > 0)
{
charRects['\t'].width = tab;
}
Expand Down
2 changes: 1 addition & 1 deletion DGEngine.core/src/SFML/Sprite2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ void Sprite2::draw(sf::RenderTarget& target, GameShader* spriteShader,
}

if (updateAll == true ||
ignore2 != cache->outline)
ignore2 != cache->ignore)
{
if (cache != nullptr)
{
Expand Down
4 changes: 2 additions & 2 deletions DGEngine.core/test/src/Parser/Utils/ParseUtilsVal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1694,8 +1694,8 @@ TEST_CASE("Parser::getPrimitiveTypeVal", "Parser")

CHECK(Parser::getPrimitiveTypeVal(doc["key01"]) == sf::PrimitiveType::Points);
CHECK(Parser::getPrimitiveTypeVal(doc["key02"], sf::PrimitiveType::Points) == sf::PrimitiveType::Points);
CHECK(Parser::getPrimitiveTypeVal(doc["key03"]) == sf::PrimitiveType::TrianglesStrip);
CHECK(Parser::getPrimitiveTypeVal(doc["key04"]) == sf::PrimitiveType::TrianglesStrip);
CHECK(Parser::getPrimitiveTypeVal(doc["key03"]) == sf::PrimitiveType::TriangleStrip);
CHECK(Parser::getPrimitiveTypeVal(doc["key04"]) == sf::PrimitiveType::TriangleStrip);
}

// Parser::getQueryVal == JsonUtils::query
Expand Down
8 changes: 4 additions & 4 deletions gamefilesc/level/loadAmateur.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel.json",
"load": "level/levelOptionsAmateur.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel.json",
"load.levelOptions": "level/levelOptionsAmateur.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
8 changes: 4 additions & 4 deletions gamefilesc/level/loadAmateur1.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel1.json",
"load": "level/levelOptionsAmateur.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel1.json",
"load.levelOptions": "level/levelOptionsAmateur.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
8 changes: 4 additions & 4 deletions gamefilesc/level/loadAmateur2.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel2.json",
"load": "level/levelOptionsAmateur.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel2.json",
"load.levelOptions": "level/levelOptionsAmateur.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
16 changes: 8 additions & 8 deletions gamefilesc/level/loadArcade.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"load": "level/baseLevel2.json",
"load": "level/levelOptionsArcade.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json",
"load": "level/baseLevel1.json",
"load": "level/levelOptionsArcade.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel2": "level/baseLevel2.json",
"load.levelOptions2": "level/levelOptionsArcade.json",
"load.highScores2": "level/highScores.json",
"load.jewelClasses2": "level/jewelClasses.json",
"load.baseLevel1": "level/baseLevel1.json",
"load.levelOptions1": "level/levelOptionsArcade.json",
"load.highScores1": "level/highScores.json",
"load.jewelClasses1": "level/jewelClasses.json"
}
8 changes: 4 additions & 4 deletions gamefilesc/level/loadNovice.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel.json",
"load": "level/levelOptionsNovice.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel.json",
"load.levelOptions": "level/levelOptionsNovice.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
8 changes: 4 additions & 4 deletions gamefilesc/level/loadNovice1.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel1.json",
"load": "level/levelOptionsNovice.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel1.json",
"load.levelOptions": "level/levelOptionsNovice.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
8 changes: 4 additions & 4 deletions gamefilesc/level/loadNovice2.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel2.json",
"load": "level/levelOptionsNovice.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel2.json",
"load.levelOptions": "level/levelOptionsNovice.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
8 changes: 4 additions & 4 deletions gamefilesc/level/loadPro.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel.json",
"load": "level/levelOptionsPro.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel.json",
"load.levelOptions": "level/levelOptionsPro.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
8 changes: 4 additions & 4 deletions gamefilesc/level/loadPro1.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel1.json",
"load": "level/levelOptionsPro.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel1.json",
"load.levelOptions": "level/levelOptionsPro.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
8 changes: 4 additions & 4 deletions gamefilesc/level/loadPro2.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"load": "level/baseLevel2.json",
"load": "level/levelOptionsPro.json",
"load": "level/highScores.json",
"load": "level/jewelClasses.json"
"load.baseLevel": "level/baseLevel2.json",
"load.levelOptions": "level/levelOptionsPro.json",
"load.highScores": "level/highScores.json",
"load.jewelClasses": "level/jewelClasses.json"
}
4 changes: 2 additions & 2 deletions gamefilesc/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"keepAR": true,
"stretchToFit": true,
"smoothScreen": true,
"load": "settings.json",
"load": "res/updateSettings.json",
"load.settings": "settings.json",
"load.updateSettings": "res/updateSettings.json",
"init": true
},
"action": { "name": "load", "file": "ui/loadMain.json" }
Expand Down
12 changes: 6 additions & 6 deletions gamefilesc/ui/loadMain.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"load": "res/actions.json",
"load.actions": "res/actions.json",
"game": {
"icon": "res/icon.png",
"onClose": "saveSettingsAndClose"
},
"load": "res/textures.json",
"load": "res/fonts.json",
"load": "ui/gameInputEvents.json",
"load": "ui/inputEvents.json",
"load": "ui/mainMenu.json"
"load.textures": "res/textures.json",
"load.fonts": "res/fonts.json",
"load.gameInputEvents": "ui/gameInputEvents.json",
"load.inputEvents": "ui/inputEvents.json",
"load.mainMenu": "ui/mainMenu.json"
}
6 changes: 3 additions & 3 deletions gamefilesc/ui/mainMenu.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}
}
],
"load": "res/mainMenuTextures.json",
"load.textures": "res/mainMenuTextures.json",
"replaceVars": "value",
"image": {
"id": "background",
Expand All @@ -63,7 +63,7 @@
"id": "menuPanel",
"visible": false
},
"image": {
"image.menu": {
"id": "menuImg",
"panel": "menuPanel",
"position": ["center", "|$.#scale * 128|"],
Expand Down Expand Up @@ -124,5 +124,5 @@
}
]
},
"load": "ui/mainMenuStart.json"
"load.start": "ui/mainMenuStart.json"
}
2 changes: 1 addition & 1 deletion gamefilesc/ui/menu/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@
}
],
"replaceVars": "value",
"action": [
"action.2": [
{
"name": "action.set",
"id": "selectBGMClotho",
Expand Down
4 changes: 2 additions & 2 deletions gamefilesc/ui/menu/menuFlash.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
}
],
"replaceVars": "value",
"button": {
"button.background": {
"id": "background",
"anchor": "none",
"texture": "options",
Expand Down Expand Up @@ -254,7 +254,7 @@
"pause": true
}
],
"action": [
"action.update": [
"updateBGM",
"updateHeight",
"updateHeightP2",
Expand Down
4 changes: 2 additions & 2 deletions gamefilesc/ui/menu/menuFlashMatch.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
}
],
"replaceVars": "value",
"button": {
"button.background": {
"id": "background",
"anchor": "none",
"texture": "options",
Expand Down Expand Up @@ -283,7 +283,7 @@
"pause": true
}
],
"action": [
"action.update": [
"updateBGM",
"updateMatch",
"updateHeight",
Expand Down
4 changes: 2 additions & 2 deletions gamefilesc/ui/menu/menuOriginal.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
}
],
"replaceVars": "value",
"button": {
"button.background": {
"id": "background",
"anchor": "none",
"texture": "options",
Expand Down Expand Up @@ -301,7 +301,7 @@
"pause": true
}
],
"action": [
"action.update": [
"updateBGM",
"updateTimeTrial",
"updateLevel",
Expand Down
2 changes: 1 addition & 1 deletion gamefilesc/ui/options/soundTest.json
Original file line number Diff line number Diff line change
Expand Up @@ -172,5 +172,5 @@
}
]
},
"action": { "name": "menu.setFont", "id": "menu", "index": 8, "font": "font1White" }
"action.update": { "name": "menu.setFont", "id": "menu", "index": 8, "font": "font1White" }
}
10 changes: 5 additions & 5 deletions gamefilesc/ui/play/arcade.json
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,11 @@
"binding": "%level2.jewels%"
}
],
"replaceVars": false,
"load": "level/loadArcade.json",
"load": "ui/play/pause1.json",
"load": "ui/play/pause2.json",
"action": [
"replaceVars.disable": false,
"load.level": "level/loadArcade.json",
"load.pause1": "ui/play/pause1.json",
"load.pause2": "ui/play/pause2.json",
"action.game": [
{
"name": "action.set",
"id": "newGame",
Expand Down
8 changes: 4 additions & 4 deletions gamefilesc/ui/play/flash.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@
"horizontalAlign": "right"
}
],
"replaceVars": false,
"load": "level/load.json",
"load": "ui/play/pause.json",
"action": [
"replaceVars.disable": false,
"load.level": "level/load.json",
"load.pause": "ui/play/pause.json",
"action.game": [
{
"replaceVars": "value",
"name": "action.set",
Expand Down
10 changes: 5 additions & 5 deletions gamefilesc/ui/play/flash2p.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@
"horizontalAlign": "right"
}
],
"replaceVars": false,
"load": "level/load2.json",
"load": "ui/play/pause1.json",
"load": "ui/play/pause2.json",
"action": [
"replaceVars.disable": false,
"load.level": "level/load2.json",
"load.pause1": "ui/play/pause1.json",
"load.pause2": "ui/play/pause2.json",
"action.game": [
{
"replaceVars": "value",
"name": "action.set",
Expand Down
Loading

0 comments on commit 7148a2a

Please sign in to comment.