checks: Check the overall length of "interrupt-map"

It is possible the overall length of "interrupt-map" is shorter than expected. A likely scenario is if "#address-cells" in the interrupt parent is not accounted for and there is only a single map entry. With multiple entries, one of the other tests would likely fail. Signed-off-by: Rob Herring (Arm) <[email protected]> Message-ID: <[email protected]> Signed-off-by: David Gibson <[email protected]>
dgibson · Jun 1, 2024 · c17d76a · c17d76a
1 parent ae26223
commit c17d76a
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/checks.c b/checks.c
@@ -1675,6 +1675,10 @@ static void check_interrupt_map(struct check *c,
 			parent_cellsize += propval_cell(cellprop);
 
 		cell += 1 + parent_cellsize;
+		if (cell > map_cells)
+			FAIL_PROP(c, dti, node, irq_map_prop,
+				"property size (%d) mismatch, expected %zu",
+				irq_map_prop->val.len, cell * sizeof(cell_t));
 	}
 }
 WARNING(interrupt_map, check_interrupt_map, NULL, &phandle_references, &addr_size_cells, &interrupt_provider);