Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rake task to load DB from local file #555

Merged
merged 4 commits into from
Dec 11, 2024
Merged

feat: rake task to load DB from local file #555

merged 4 commits into from
Dec 11, 2024

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Dec 11, 2024 •
edited
Loading

  • add a rake task to load DB w/ local sql dump
  • remove rake task to download from remote. It depends on a static s3:///dgidb/dgidb_latest.sql URI and I'm not really happy with maintaining that. I'd rather have a better way of dynamically pointing to the latest-dated dump. Also, I thought some of the data was supposed to be private but I could be wrong.
  • slightly reconfigure the section for psql executable injection into the PATH. Drop macports support. Add homebrew (ARM64) support.

@jsstevenson jsstevenson added the priority:low Low priority label Dec 11, 2024
@jsstevenson jsstevenson requested a review from acoffman December 11, 2024 15:51
acoffman
acoffman approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@acoffman acoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I forgot that Macports stuff was even still there!

@jsstevenson jsstevenson merged commit 7e0df22 into dev Dec 11, 2024
5 checks passed
@jsstevenson jsstevenson deleted the db-rake-tasks branch December 11, 2024 17:44
@jsstevenson jsstevenson mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoffman acoffman acoffman approved these changes

Assignees
No one assigned
Labels
priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsstevenson @acoffman