-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add movie data set with GraphQL schema #41
Open
danielmai
wants to merge
12
commits into
master
Choose a base branch
from
danielmai/dgraph-1006-graphql-schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No @lang directives in Dgraph schema. * No @count directives in Dgraph schema to avoid time waiting for it to be removed when setting the GraphQL schema. * Use removelangs.go to filter out language strings. Only keep the English ones. * simple.graphql is a basic GraphQL schema with a subset of the fields from the movie dataset.
This file is for reference purposes only. It's not ready as-is to be used as a GraphQL schema. 1. The types aren't the same names as the Dgraph types. 2. Reverse edges aren't set properly. 3. GraphQL directives aren't used. 4. Other things too.
curl http://localhost:8080/admin/schema --upload-file ./schema.graphql {"errors":[{"message":"resolving updateGQLSchema failed because input:200: Type FestivalSponsorship; Field festivals: has type [Film], which is different to type FestivalSponsor; field festivals, which has the same @dgraph directive but type [Festival]. These fields must have either the same GraphQL types, or use different Dgraph predicates.\ninput:329: Type PersonalAppearance; Field appearances: has type [PersonalAppearanceType], which is different to type Performance; field appearances, which has the same @dgraph directive but type [PersonalAppearance]. These fields must have either the same GraphQL types, or use different Dgraph predicates.\n (Locations: [{Line: 3, Column: 4}])","extensions":{"code":"Error"}}]}
This was used during testing instead of the entire schema.graphql.
GraphQL doesn't support geo types, and theese two predicates don't exist in the 19miillion.rdf.gz dataset anyway. These were taken from the release/21miillion.schema file.
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following files for a movie data set for Dgraph GraphQL:
The 19million.rdf.gz was created from the 21million.rdf.gz with the human-language
@lang
support removed, since GraphQL doesn't currently support human languages.The GraphQL schema uses the
@dgraph
directive for all the fields to use the original movie data set fields as-is.This change is