fix(Snapshot): Improve snapshot handling #7841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mangalaman93
requested review from
mangalaman93,
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
mangalaman93
force-pushed
the
mrjn/improve-snapshot-handling
branch
2 times, most recently
from
6624e52
to
04e83af
Compare
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
mangalaman93
requested changes
Aug 12, 2024
| @@ -912,13 +912,19 @@ func (n *node) retrieveSnapshot(snap pb.Snapshot) error { | |||
| var pool *conn.Pool | |||
| addr := snap.Context.GetAddr() | |||
| glog.V(2).Infof("Snapshot.RaftContext.Addr: %q", addr) | |||
| if len(addr) > 0 { | |||
| if addr == n.MyAddr { | |||
There was a problem hiding this comment.
won't we always steam from leader to follower? And what happens when we skip it?
mangalaman93
force-pushed
the
mrjn/improve-snapshot-handling
branch
from
04e83af
to
648b121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitor for stuck snapshots in both directions, sender and receiver. If any of them is stuck for a while, cancel snapshot transfer.
This change is