test(upgrade): add upgrade tests for systest/plugin #8896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraph-bot
added
area/testing
mangalaman93
requested review from
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
mangalaman93
requested changes
Jul 6, 2023
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
from
adb5749
to
4e90467
Compare
mangalaman93
requested changes
Jul 11, 2023
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
from
4e90467
to
770c3fd
Compare
mangalaman93
requested changes
Jul 26, 2023
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
2 times, most recently
from
b4fc0b2
to
dc06871
Compare
mangalaman93
requested changes
Jul 26, 2023
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
from
dc06871
to
2c42783
Compare
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
from
2c42783
to
f22c1e7
Compare
mangalaman93
requested changes
Aug 3, 2023
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
from
f22c1e7
to
02ac64f
Compare
mangalaman93
previously approved these changes
Aug 3, 2023
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
4 times, most recently
from
cd9b84f
to
a25dd3f
Compare
mangalaman93
requested changes
Aug 13, 2023
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
from
a25dd3f
to
d86341f
Compare
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
5 times, most recently
from
ee932d6
to
58d1bc2
Compare
mangalaman93
previously approved these changes
Aug 21, 2023
mangalaman93
changed the title
all-seeing-code
suggested changes
Aug 21, 2023
There was a problem hiding this comment.
Would you mind providing some more details in the PR description about the motivation behind this change and a description of the tests? Additionally, I'd be grateful if you could help me understand the role of plugins within dgraph. An example here would be really insightful. Thank you!
jbhamra1
force-pushed
the
jassi/systest_plugin
branch
from
58d1bc2
to
f8e82b5
Compare
mangalaman93
previously approved these changes
Aug 23, 2023
…ContainerKill() called from it
mangalaman93
force-pushed
the
jassi/systest_plugin
branch
from
f8e82b5
to
20936aa
Compare
mangalaman93
approved these changes
Aug 28, 2023
all-seeing-code
approved these changes
Aug 29, 2023
| @@ -57,7 +58,9 @@ type LocalCluster struct { | |||
| tempBinDir string | |||
| tempSecretsDir string | |||
| encKeyPath string | |||
| lowerThanV21 bool | |||
|
|
|||
| lowerThanV21 bool | |||
There was a problem hiding this comment.
why do we need this boolean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an existing 'integration' test, now transformed to run for 'integration' and 'upgrade' using dgraphtest framework. Additionally, leveraging 'testify/suite' package's SetupTest() / SetupSubTest() / TeardownTest() / TeardownSubTest() functionality during the test runs. 'integration' tests are still run using t.go and the dgraphtest framework acts as a no-op for now. Going forward, there are plans to have dgraphtest framework take over the t.go. 'upgrade' used in the tests is Dgraph version upgrade from a source version to a target version using 'BackupRestore' and 'InPlace'.
Plugin insights: Hope this link will help here https://dgraph.io/docs/query-language/indexing-custom-tokenizers/#implementing-a-plugin
Closes: https://dgraph.atlassian.net/browse/DGRAPHCORE-304