Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing Dgraph cd pipeline to only push images to Dockerhub when both AMD and ARM builds are successful #9202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enhancing Dgraph cd pipeline to only push images to Dockerhub when both AMD and ARM builds are successful #9202

wants to merge 2 commits into from
+16 −33

Conversation

meghalims
Copy link
Contributor

Dgraph CD pipeline was prematurely publishing Docker images to DockerHub even when one of the architectures failed. This PR makes the following changes to prevent this:

  • dgraph-build-amd64 and dgraph-build-arm64 jobs build their respective images. But do not push them to DockerHub.
  • Job dgraph-docker-manifest is renamed to dgraph-docker-image-and-manifests-push to reflect that it also pushes docker images for Dgraph/Custom/Standalone

@meghalims meghalims requested a review from a team as a code owner October 18, 2024 19:51
@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel Awaiting requested review from harshil-goel

@mangalaman93 mangalaman93 Awaiting requested review from mangalaman93

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/integrations Related to integrations with other projects.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@meghalims