Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batteryLevel to check secondary battery #1422

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

stanaka
Copy link
Contributor

@stanaka stanaka commented May 26, 2024

The current logic checks only the primary battery even each camera has a secondary battery.
This PR fixes this issue by checking the secondary battery in getBatteryLevel method.

Related issue: #1312

Copy link
Owner

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated logic! I don't have any cameras with two batteries so I haven't run into corner cases associated with the second battery

@dgreif dgreif changed the base branch from main to beta July 16, 2024 14:27
@dgreif dgreif merged commit 4a6cc59 into dgreif:beta Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants