notes about point order blocking some polygon conversion

dgtized · Nov 23, 2023 · 4c614ba · 4c614ba
1 parent 088acf1
commit 4c614ba
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/shimmers/math/geometry/rectangle.cljc b/src/shimmers/math/geometry/rectangle.cljc
@@ -29,6 +29,9 @@
   (left-side (rect/rect 5))
   (map g/bounds (lines/cut-polygon (rect/rect 10) (left-side (rect/rect 2 0 6 10)))))
 
+;; FIXME: handle if point order is rotated (also cw/ccw)?
+;; ie a-b  vs b-c  vs c-d
+;;    d-c     a-d     b-a
 (defn polygon->rectangle
   "Convert a `polygon` to a `Rect2` iff it has 4 points and they are axis aligned.
 

diff --git a/src/shimmers/sketches/divisible.cljs b/src/shimmers/sketches/divisible.cljs
@@ -86,9 +86,10 @@
                             (mapcat (fn [r] (punch-out r box)) rects))
                           [bounds]
                           punches)]
-    (concat (map (fn [s] (if (instance? Polygon2 s)
-                          (vary-meta s assoc :fill "#ddd")
-                          s))
+    (concat (map (fn [s]
+                   (if (instance? Polygon2 s)
+                     (vary-meta s assoc :fill "#ddd")
+                     s))
                  (reduce reduce-overlapping
                          remaining
                          punches))