Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger menu #410

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TanmayKalra09
Copy link
Contributor

Pull Request Template for GSoC 2024

Related Issue

None

closes: #396

Description of Changes

Previously Navbar was working like ham burger menu, I have implemented proper Hamburger menu and also enhanced it.

Type of Pull Request

  • Bug Fix
  • New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): _______________

(Please check relevant boxes by entering an "X" inside them)

Screenshots / Demo (if applicable)

image

[Include any screenshots, GIFs, or videos that demonstrate the change or feature, if available.]

Checklist for Contributor

use'X' in [ ] to check it .

  • I have reviewed my code before submission.
  • I have read and followed the project's Contribution Guidelines.
  • I have tested the code thoroughly.
  • I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • I have checked the existing code base and my changes do not introduce any breaking changes.
  • My PR addresses only one issue; I have created separate PRs for other issues.
  • I have ensured that the PR does not include unrelated files.
  • I am mindful of the project's coding standards and best practices.

Additional Information

[Include any additional context or relevant information that may help in reviewing this PR.]

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:04pm
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:04pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi
Copy link
Owner

previous one is good keep it as figma design please @TanmayKalra09

@dhairyagothi
Copy link
Owner

also increase some width

@TanmayKalra09
Copy link
Contributor Author

Hey @dhairyagothi, I have changed the hamburger menu which is inspired by Figma design. Secondly, I have increased the width of the hamburger menu from 250px to 350px

image

@dhairyagothi
Copy link
Owner

conflicts @TanmayKalra09

@dhairyagothi
Copy link
Owner

image

check this navbar
also change width to w-1/4

Copy link
Owner

@dhairyagothi dhairyagothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use tailwind css its hard to handle a lot files of css as well as jsx

@TanmayKalra09
Copy link
Contributor Author

TanmayKalra09 commented Oct 24, 2024

@dhairyagothi done with the changes.
Menu width is now 25%, and tailwind is used.

@dhairyagothi
Copy link
Owner

image

fix this also search icon is not there

@TanmayKalra09
Copy link
Contributor Author

@dhairyagothi Please review the changes.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in Hamburger Menu
2 participants