Use the libvirt API to obtain domain IP address #40
Conversation
| @@ -1,4 +1,4 @@ | |||
| default: build | |||
|
|
|||
| build: | |||
| GOGC=off go build -i -o docker-machine-driver-kvm | |||
| GOGC=off go build -tags libvirt.1.2.14 -i -o docker-machine-driver-kvm | |||
There was a problem hiding this comment.
Unfortunately I don't have a physical ubuntu 14.04 box (or other older LTS distro) to try this out at the moment. Was this alone sufficient to have this all hold together where it both compiles and doesn't do something nasty at runtime when the underlying API isn't present? Maybe enough time has passed that we can ignore the older LTS distros, but I was hoping to keep this compatible for a while if possible.
There was a problem hiding this comment.
I don't have access to such a machine. However latest Ubuntu LTS (xenial 16.04LTS) has version 1.3.1 available.
Personally I would ignore 14.04.
There was a problem hiding this comment.
I've been meaning to improve the build a bit... and this helped motivate me to get some extra build support in place to generate binaries for various host systems. f328c4b
I think we should be able to at least partially answer the compatibility question on this PR by seeing if it builds on ubuntu14.04. Then we could try to do a create in a container, which should fail due to the missing libvirt socket, but as long as it errors that way and not with some obscure C lib link problem, then I think we're good.
There was a problem hiding this comment.
I rebased my changes against your master, this is the error I get when I try to build the code inside of 14.04:
# github.com/dhiltgen/docker-machine-kvm
./kvm.go:596: cannot use uint(libvirt.DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE) (type uint) as type libvirt.DomainInterfaceAddressesSource in argument to d.VM.ListAllInterfaceAddresses
Do you think it's acceptable?
Requires libvirt >= 1.2.6. The tag libvirt.1.2.14 is required by libvirt-go to enable its use, since a wider range of libvirt versions are supported there. Initial patch provided by Casey Marshall <[email protected]>
Changed the code to use the native libvirt API provided by the official Go bindings. Signed-off-by: Flavio Castelli <[email protected]>
flavio
force-pushed
the
libvirt-address-api
branch
from
ccf9e5a
to
f720110
Compare
This is a complete revamp of #2.
The code has been changed to use the right API provided by the official libvirt-go bindings. The previous PR was using a different Go binding library.