fix: org unit access in search [DHIS2-16268] #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1324--dhis2-user.netlify.app |
kabaros
approved these changes
Dec 11, 2023
tomzemp
force-pushed
the
DHIS2-16268/search-results
branch
from
875cf3d
to
0474a2f
Compare
dhis2-bot
added a commit
that referenced
this pull request
Dec 11, 2023
## [1.5.34](v1.5.33...v1.5.34) (2023-12-11) ### Bug Fixes * org unit access in search [DHIS2-16268] ([#1324](#1324)) ([8dd538f](8dd538f))
|
🎉 This PR is included in version 1.5.34 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
tomzemp
added a commit
that referenced
this pull request
Dec 11, 2023
* fix: org unit access in search [DHIS2-16268] * fix: add tests
tomzemp
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where organisation units were not appearing in search results because the user was deemed not to have access to the organisation unit. Note: this issue was for users without ALL authority (e.g.
adminon our play instances)Issue was that the code was assuming that api/me returned an array of orgUnit ids, but instead we are getting an array of objects like [{id: "someOrgUnit"}] (maybe this was an api change at some point?)
Before
After
(P.S. I noticed another bug that if you have clicked on multiple of these org unit selection search fields, the search results will appear in all of them, but I don't want to look at/fix that here)