fix: update user group form (v38) [DHIS2-12294] #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomzemp
force-pushed
the
DHIS2-12294/v38/update-user-groups
branch
from
b1934db
to
4b5d6a0
Compare
|
🚀 Deployed on https://pr-1328--dhis2-user.netlify.app |
tomzemp
changed the title
|
should we wait for Viet's fixes? |
Mohammer5
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user app's User Group form got refactored in v39 to add bulk user management and at that time it was also amended to use json+patch api.
The user group managedGroups users appears only to work with the json+patch, so I have replicated the v39 changes to UserGroup form in v38 (except for the bulk user management).
On the downside, the code updates do not seem to work (but this bug with not being able to update user group code also exists on v41, v40, v39, so I think merging the change here and then fixing the code update issue is probably better?). UPDATE: Viet is working on a fix for that issue (https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-16299?)