feat: add a default notice box based on access level of the user #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1364--dhis2-user.netlify.app |
…roupDetails page chore: fix lint error chore: fix lint error
Chisomchima
force-pushed
the
DHIS2-17083/user-group-access-update
branch
from
4389ae3
to
619186d
Compare
tomzemp
requested changes
Apr 29, 2024
There was a problem hiding this comment.
@Chisomchima: notice box looks great 🎉, but I think you need to refine the logic slightly (see comment)
| @@ -34,6 +34,12 @@ const GroupDetails = ({ groupId }) => { | |||
|
|
|||
| return ( | |||
| <Details title={group.displayName}> | |||
| {group.access.read && ( | |||
There was a problem hiding this comment.
Hi @Chisomchima. I think you need to display this when !group?.access?.write.
At the moment, because you display the message whenever a user has read access, the user will see this message if they have both read and write access to the group, e.g.:
|
🎉 This PR is included in version 100.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Chisomchima
added a commit
that referenced
this pull request
May 8, 2024
feat: add a default notice box based on access level of the user
4 tasks
Chisomchima
added a commit
that referenced
this pull request
May 8, 2024
feat: add a default notice box based on access level of the user
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17083
Description
conditionally display update status in user group details page based on access levels
Known issues
Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots