V2.0.1 Make category OnlyList as per spec

dhvcc · Sep 26, 2024 · 5d03c8c · 5d03c8c
1 parent a75867b
commit 5d03c8c
Show file tree

Hide file tree

Showing 10 changed files with 169 additions and 4 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -49,6 +49,7 @@ pre-commit = "^2.12.0"
 ruff = "*"
 rich = "*"
 pytest = "^7.4.0"
+requests = "^2.32.3"
 
 [tool.pytest.ini_options]
 addopts = "--color=yes"

diff --git a/rss_parser/models/rss/channel.py b/rss_parser/models/rss/channel.py
@@ -47,7 +47,7 @@ class OptionalChannelElementsMixin(XMLBaseModel):
     last_build_date: Optional[Tag[DateTimeOrStr]] = None  # Sat, 07 Sep 2002 09:42:31 GMT
     "The last time the content of the channel changed."
 
-    category: Optional[Tag[str]] = None  # Newspapers
+    categories: Optional[OnlyList[Tag[str]]] = pydantic.Field(alias="category", default=[])
     "Specify one or more categories that the channel belongs to. Follows the same rules as the <item.py>-level " "category element."  # noqa
 
     generator: Optional[Tag[str]] = None  # MightyInHouse Content System v2.3

diff --git a/rss_parser/models/rss/item.py b/rss_parser/models/rss/item.py
@@ -26,7 +26,7 @@ class OptionalItemElementsMixin(XMLBaseModel):
     author: Optional[Tag[str]] = None
     "Email address of the author of the item."
 
-    category: Optional[Tag[str]] = None
+    categories: Optional[OnlyList[Tag[str]]] = pydantic.Field(alias="category", default=[])
     "Includes the item in one or more categories."
 
     comments: Optional[Tag[str]] = None

diff --git a/tests/samples/apology_line/result.pkl b/tests/samples/apology_line/result.pkl
diff --git a/tests/samples/github-49/result.pkl b/tests/samples/github-49/result.pkl
diff --git a/tests/samples/rss_2/result.pkl b/tests/samples/rss_2/result.pkl
diff --git a/tests/samples/rss_2_no_category_attr/result.pkl b/tests/samples/rss_2_no_category_attr/result.pkl
diff --git a/tests/samples/rss_2_with_1_item/result.pkl b/tests/samples/rss_2_with_1_item/result.pkl
diff --git a/tests/test_parsing.py b/tests/test_parsing.py
@@ -1,4 +1,5 @@
 import logging
+import pickle
 from typing import Type
 
 import pytest