#3: Fixed the Plugin loader when loading plugins from 3rd party packages. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… party packages. See diablomedia#3 The plugin loader does not load plugins from 3thd party packages (eg. https://github.com/AMOSoft/zf1-extras). This because the loader is checking if tha class exists without allowing autoload to work. This is old ZF1 code from pre-composer era. Changing the code in the /src/Zend/Loader/PluginLoader.php file fixes this issue.
zero2one
changed the title
|
@zero2one I actually ran into this same issue when I was extracting this component from the main zf1 repo, as I thought it would be nice if it would use the autoloader here for similar reasons. However, when this change is made, this test in the main ZF1 repo fails: https://github.com/diablomedia/zf1/blob/master/tests/Zend/Amf/ServerTest.php#L1065 In the doc-block of that test, it refers to this ZF ticket: http://www.zendframework.org.cn/issues/browse/ZF-6625 We don't personally use Zend_Amf, but I didn't want to revert a change that was made to fix a security vulnerability, especially if anyone may be using our fork of ZF1 and are using Zend_Amf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed checking if a class exists by using the composer autoloader.