Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix issue with trailCrossings #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Attempt to fix issue with trailCrossings #338

wants to merge 1 commit into from

Conversation

bacchanalia
Copy link

This is an attempted fix for issue #337. While it gets rid of some
instances where test falsely returns a zero value, it is possible it may
introduce some instances where test falsely returns a non-zero value.

Attempt to fix issue with trailCrossings
5c4ea58 
This is an attempted fix for issue diagrams#337. While it gets rid of some
instances where test falsely returns a zero value, it is possible it may
introduce some instances where test falsely returns a non-zero value.
@bacchanalia
Copy link
Author

Some outstanding questions I have relating to this PR:

  1. Are there any cases where 1 < t < 1+eps where we actually want to signFromDerivAt to return 0 instead of 1?
  2. Are there any cases where -eps < t < 0 where we actually want to signFromDerivAt to return 0 instead of -1?
  3. Are the changes form 0 to -eps necessary or are they prevented because of the change in sign?
  4. Are we worried about fp error in ang and do should we have eps terms in those comparisons also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bacchanalia