Added PAX archive format support to minicoredumper to overcome core size limit of 8GB. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion 2.0.6 Summary - minicoredumper-2.0.6 lacks support for archiving > 8GB dumps. - patch adds support for larger cores using POSIX archive format. - includes sparse file support with format '1.0'. This change contain - modified etc/generic.recept.json to include "use_posix_for_tar" key. (Below changes in minicoredumper-2.0.6/src) - prog_config.c & prog_config.h : added recept json option "use_posix_for_tar" under the "compression" entry with default value "true". - tar.h : contains the structs for gnu and posix tar archives. - added some comments in corestripper.c - major functions added to corestripper.c are - dump_compressed_posix_tar - write_pax_extended_entry - fill_name_in_pax_header - build_sparse_map_linked_list - modified the below functions in corestripper.c for PAX format support - check_core_size - dump_compressed_core - dump_compressed_tar References - https://www.ibm.com/docs/en/zos/2.3.0?topic=ff-pax-format-pax-archives-special-header-summary-files - https://pubs.opengroup.org/onlinepubs/9699919799/utilities/pax.html - https://www.gnu.org/software/tar/manual/html_node/PAX-1.html#PAX-1 Signed-off-by: Prakhar Pandey <[email protected]>
ShaharHD
reviewed
Jul 9, 2024
|
|
||
| /* Fill in checksum and sparse map block (block 4) size in tar block 2. */ | ||
| snprintf(sparse_file_hdr.numbytes, sizeof(sparse_file_hdr.numbytes), | ||
| "%011" PRIo64, strlen(sparse_map_block)); |
There was a problem hiding this comment.
Got an error
'%011lo' directive output may be truncated writing between 11 and 21 bytes into a region of size 12 [-Werror=format-truncation=]
Should we just ignore the warning? or is it a possible bug? my work around:
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wformat-truncation"
snprintf(sparse_file_hdr.numbytes, sizeof(sparse_file_hdr.numbytes),
"%011" PRIo64, strlen(sparse_map_block));
#pragma GCC diagnostic pop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAX archive format is used to fix the below:
Summary
This change contain
References