Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added binary chop algorithm to speed up finding a string that fits. #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

btwelch
Copy link

@btwelch btwelch commented Oct 25, 2016

This pull request introduces a binary chop algorithm to significantly improve the search for the best-fit string size for a given container. Without this, using a character-by-character (blank-ellipses-separator) check would be very inefficient.

@kevindice
Copy link

This would help me out a lot. I've got an infinite scroll feed with each item using this directive. Performance is suffering a bit right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants