Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dice in RollResult #252

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Include dice in RollResult #252

wants to merge 1 commit into from

Conversation

erik-jenkins
Copy link

No description provided.

@erik-jenkins erik-jenkins requested a review from GreenImp as a code owner April 30, 2022 19:49
@erik-jenkins erik-jenkins mentioned this pull request Apr 30, 2022
Open
GreenImp
GreenImp requested changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@GreenImp GreenImp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄
It would be good to add some tests to ensure that an error is thrown if you try to set something that isn't a Dice object. And also some tests to make sure that exporting / importing, and serialising to JSON still works.

src/results/RollResult.js
}

set dice(value) {
this[diceSymbol] = value;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a check to throw an error if the value isn't a dice object?

@GreenImp GreenImp force-pushed the develop branch 3 times, most recently from 4ff7fb9 to 03379d6 Compare May 12, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreenImp GreenImp GreenImp requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-jenkins @GreenImp