fix return type of built-in artisan commands

dicoding-dev · Nov 17, 2023 · add9451 · add9451
1 parent 71575a0
commit add9451
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 14 deletions.
diff --git a/src/Illuminate/Queue/Console/FailedTableCommand.php b/src/Illuminate/Queue/Console/FailedTableCommand.php
@@ -42,15 +42,17 @@ public function __construct(Filesystem $files)
 	/**
 	 * Execute the console command.
 	 *
-	 * @return void
-	 */
+	 * @return int
+     */
 	public function fire()
 	{
 		$fullPath = $this->createBaseMigration();
 
 		$this->files->put($fullPath, $this->files->get(__DIR__.'/stubs/failed_jobs.stub'));
 
 		$this->info('Migration created successfully!');
+
+        return 0;
 	}
 
 	/**

diff --git a/src/Illuminate/Queue/Console/FlushFailedCommand.php b/src/Illuminate/Queue/Console/FlushFailedCommand.php
@@ -21,7 +21,6 @@ class FlushFailedCommand extends Command {
 	/**
 	 * Execute the console command.
 	 *
-	 * @return void
 	 */
 	public function fire()
 	{

diff --git a/src/Illuminate/Queue/Console/ForgetFailedCommand.php b/src/Illuminate/Queue/Console/ForgetFailedCommand.php
@@ -22,8 +22,8 @@ class ForgetFailedCommand extends Command {
 	/**
 	 * Execute the console command.
 	 *
-	 * @return void
-	 */
+	 * @return int
+     */
 	public function fire()
 	{
 		if ($this->laravel['queue.failer']->forget($this->argument('id')))
@@ -34,6 +34,8 @@ public function fire()
 		{
 			$this->error('No failed job matches the given ID.');
 		}
+
+        return 0;
 	}
 
 	/**

diff --git a/src/Illuminate/Queue/Console/ListFailedCommand.php b/src/Illuminate/Queue/Console/ListFailedCommand.php
@@ -21,8 +21,8 @@ class ListFailedCommand extends Command {
 	/**
 	 * Execute the console command.
 	 *
-	 * @return void
-	 */
+	 * @return int
+     */
 	public function fire()
 	{
 		$rows = array();
@@ -34,14 +34,17 @@ public function fire()
 
 		if (count($rows) == 0)
 		{
-			return $this->info('No failed jobs!');
+			$this->info('No failed jobs!');
+            return 0;
 		}
 
 		$table = $this->getHelperSet()->get('table');
 
 		$table->setHeaders(array('ID', 'Connection', 'Queue', 'Class', 'Failed At'))
               ->setRows($rows)
               ->render($this->output);
+
+        return 0;
 	}
 
 	/**

diff --git a/src/Illuminate/Queue/Console/RestartCommand.php b/src/Illuminate/Queue/Console/RestartCommand.php
@@ -21,13 +21,15 @@ class RestartCommand extends Command {
 	/**
 	 * Execute the console command.
 	 *
-	 * @return void
-	 */
+	 * @return int
+     */
 	public function fire()
 	{
 		$this->laravel['cache']->forever('illuminate:queue:restart', time());
 
 		$this->info('Broadcasting queue restart signal.');
+
+        return 0;
 	}
 
 }
diff --git a/src/Illuminate/Queue/Console/RetryCommand.php b/src/Illuminate/Queue/Console/RetryCommand.php
@@ -22,8 +22,8 @@ class RetryCommand extends Command {
 	/**
 	 * Execute the console command.
 	 *
-	 * @return void
-	 */
+	 * @return int
+     */
 	public function fire()
 	{
 		$failed = $this->laravel['queue.failer']->find($this->argument('id'));
@@ -42,6 +42,8 @@ public function fire()
 		{
 			$this->error('No failed job matches the given ID.');
 		}
+
+        return 0;
 	}
 
 	/**

diff --git a/src/Illuminate/Queue/Console/SubscribeCommand.php b/src/Illuminate/Queue/Console/SubscribeCommand.php
@@ -32,8 +32,8 @@ class SubscribeCommand extends Command {
 	/**
 	 * Execute the console command.
 	 *
-	 * @return void
-	 *
+	 * @return int
+     *
 	 * @throws \RuntimeException
 	 */
 	public function fire()
@@ -48,6 +48,8 @@ public function fire()
 		$iron->getIron()->updateQueue($this->argument('queue'), $this->getQueueOptions());
 
 		$this->line('<info>Queue subscriber added:</info> <comment>'.$this->argument('url').'</comment>');
+
+        return 0;
 	}
 
 	/**