-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: RN Picker 重构(移除 @ant-design) #1863
Open
wangshunnn
wants to merge
45
commits into
didi:master
Choose a base branch
from
wangshunnn:refactor-rn-picker-0221
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Feb 25, 2025
packages/webpack-plugin/lib/runtime/components/react/mpx-picker-view.tsx
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Feb 25, 2025
packages/webpack-plugin/lib/runtime/components/react/mpx-picker/index.tsx
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Feb 25, 2025
packages/webpack-plugin/lib/runtime/components/react/mpx-picker/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
picker-view
组件重构,移除之前依赖的@ant-design/react-native
PR Diff
picker
组件文件夹:packages/webpack-plugin/lib/runtime/components/react/mpx-picker
mpx-portal
封装了可扩展的弹窗管理器 hooks:packages/webpack-plugin/lib/runtime/components/react/mpx-popup/index.tsx
,方便 picker 实现类似微信的半弹层效果,未来其他内部 RN 组件可以扩展复用。jsx
lint,修复了存量jsx
lint 问题Preview
1. 普通选择器:mode = selector
2. 多列选择器:mode = multiSelector
3. 时间选择器:mode = time
4. 日期选择器:mode = date
5. 省市区选择器:mode = region