CMP-4885: - implemented isUnderage flag and DidomiInitializeParameters #143
+593
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. - Removed force unwrapping. - Removed fatalError.
felipe-saez
changed the title
nicolas-chaix-didomi
requested changes
Feb 3, 2025
nicolas-chaix-didomi
previously approved these changes
Feb 4, 2025
| @@ -319,6 +322,7 @@ class DidomiModule(reactContext: ReactApplicationContext) : ReactContextBaseJava | |||
| } | |||
|
|
|||
| @ReactMethod | |||
| @Deprecated("Use initializeWithParameters instead", replaceWith = ReplaceWith("initializeWithParameters()")) | |||
There was a problem hiding this comment.
This method is internal, maybe it is not necessary to mark it as deprecated
There was a problem hiding this comment.
I can remove it. Currently we mark other methods as deprecated as well. I'll remove those too. Let me know what you think.
nicolas-chaix-didomi
approved these changes
Feb 4, 2025
pmerlet-at-didomi
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed included:
isUnderageflag onsetUserandinitialize.initializefunction that acceptsDidomiInitializeParameters.setUserfunction that acceptsDidomiUserParameters.setUserfunctions not based onDidomiUserParameters.initializefunctions not based onDidomiInitializeParameters.fatalError.