Improve MK2 frames handling #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not ready yet |
jeanlucmongrain
commented
Jul 22, 2024
| if checkChecksum(l, frame[0], frame[1:]) { | ||
| switch frame[0] { | ||
| case bootupFrameHeader: | ||
| m.setTarget() |
There was a problem hiding this comment.
setTarget() is only executed once at startup of invertergui process. this make sure it's executed everytime Victron is started even if invertergui is running while it happens
There was a problem hiding this comment.
What do you mean by "should be all" ?
There was a problem hiding this comment.
Sorry I responded to this comment but in the wrong thread :D #44 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to fix #44