Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify array before try to access any position #75

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Verify array before try to access any position #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions jsonlogic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,16 @@ func TestIssue71_example_max(t *testing.T) {
assert.JSONEq(t, expected, result.String())
}

func TestIssue74(t *testing.T) {
logic := strings.NewReader(`{"if":[ false, {"var":"values.0.categories"}, "else" ]}`)
data := strings.NewReader(`{ "values": [] }`)

var result bytes.Buffer
_ = Apply(logic, data, &result)
expected := `"else"`
assert.JSONEq(t, expected, result.String())
}

func TestJsonLogicWithSolvedVars(t *testing.T) {
rule := json.RawMessage(`{
"or":[
Expand Down
7 changes: 6 additions & 1 deletion vars.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,12 @@ func getVar(value, data interface{}) interface{} {
}

if isSlice(data) {
_value = data.([]interface{})[int(toNumber(part))]
pos := int(toNumber(part))
container := data.([]interface{})
if pos >= len(container) {
return _default
}
_value = container[pos]
}

if _value == nil {
Expand Down
Loading