move datatest-stable into this repository #35

sunshowers · 2021-03-26T01:13:03Z

TODO before landing this:

clarify licensing situation (code's currently Apache-2.0, we'd like to relicense to MIT OR Apache-2.0 for compatibility with the Rust ecosystem)

We'd like to make this independent of the Diem repo, but it will still be tightly coupled with the test runner -- so move it into this repo.

Introduce `datatest-stable`, a data-driven testing framework that is meant to be a simple version of `datatest` that is usable with a stable rust compiler without using the `RUSTC_BOOTSTRAP` mechanism for allowing nightly features to be used with a stable compiler. Closes: #1016 Approved by: sunshowers

Closes: #1194 Approved by: huitseeker

Closes: #1609 Approved by: davidiw

- Added test framework for Move lang expected output tests - Added tests to check all of the stdlib files Closes: #1624 Approved by: vgao1996

One instance of unsafe code was deleted from libra-swarm, crates which use no unsafe code have top level `#![forbid(unsafe_code)]`, and crates which use unsafe code now forbid unsafe code in all other files. Closes: #1833 Approved by: bmwill

Bumps [regex](https://github.com/rust-lang/regex) from 1.3.4 to 1.3.5. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.3.4...1.3.5) Signed-off-by: dependabot-preview[bot] <[email protected]> Closes: #2941 Approved by: rexhoffman

Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.11 to 0.3.12. - [Release notes](https://github.com/TeXitoi/structopt/releases) - [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) - [Commits](TeXitoi/structopt@v0.3.11...v0.3.12) Signed-off-by: dependabot-preview[bot] <[email protected]> Closes: #3033 Approved by: rexhoffman

Bumps [regex](https://github.com/rust-lang/regex) from 1.3.5 to 1.3.6. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.3.5...1.3.6) Signed-off-by: dependabot-preview[bot] <[email protected]> Closes: #3121 Approved by: rexhoffman

Teach test binaries built using `datatest-stable` to be able to list the names of each test with the `--list` option. This matches the behavior of the `--list` option with test binaries built using the default test harness. Closes: #3318 Approved by: sausagee

Closes: #3328 Approved by: bmwill

Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.12 to 0.3.13. - [Release notes](https://github.com/TeXitoi/structopt/releases) - [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) - [Commits](https://github.com/TeXitoi/structopt/commits) Signed-off-by: dependabot-preview[bot] <[email protected]> Closes: #3345 Approved by: bmwill

By unifying the features requested in third party dependencies, this crate improves caching and should speed up build/test time. Each time cargo is invoked, it resolves features for its targets, but since the targets change every invocation potentially, the resolved features for third party crates might also change, causing those third party crates to be recompiled. This unifies the features among third party crates so that every feature resolution is the same for third party crates. The downside is we have dependencies to libra-workspace-hack from every first party crate, and we create new, unused dependency edges from some crates to third party dependencies. Both downsides can be mitigated by using cargo-guppy with the `--omit-edges-into libra-workspace-hack`. This solution is modeled on the one in the rust compiler, which is at https://github.com/rust-lang/rust/tree/master/src/tools/rustc-workspace-hack Closes: #3151 Approved by: sunshowers

Bumps [regex](https://github.com/rust-lang/regex) from 1.3.6 to 1.3.7. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.3.6...regex-1.3.7) Signed-off-by: dependabot-preview[bot] <[email protected]> Closes: #3505 Approved by: rexhoffman

Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.13 to 0.3.14. - [Release notes](https://github.com/TeXitoi/structopt/releases) - [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) - [Commits](TeXitoi/structopt@v0.3.13...v0.3.14) Signed-off-by: dependabot-preview[bot] <[email protected]> Closes: #3559 Approved by: wqfish

Bumps [regex](https://github.com/rust-lang/regex) from 1.3.7 to 1.3.9. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@regex-1.3.7...1.3.9) Signed-off-by: dependabot-preview[bot] <[email protected]> Closes: #4116 Approved by: rexhoffman

Closes: #4226 Approved by: metajack

Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.14 to 0.3.15. - [Release notes](https://github.com/TeXitoi/structopt/releases) - [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) - [Commits](TeXitoi/structopt@v0.3.14...v0.3.15) Signed-off-by: dependabot-preview[bot] <[email protected]> Closes: #4567 Approved by: rexhoffman

…lang-sys 1.0.0/0.23.0 collision prevented bindgen upgrade Closes: #5762

Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.17 to 0.3.18. - [Release notes](https://github.com/TeXitoi/structopt/releases) - [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) - [Commits](TeXitoi/structopt@v0.3.17...v0.3.18) Signed-off-by: dependabot[bot] <[email protected]> Closes: #6184

Closes: #6526

…ssbeam crossbeam-channel ctrlc env_logger indexmap indoc regex serde serde_derive serde_json structopt syn toml rayon serde-generate futures libc enum_dispatch syn handlebars bitvec memchr && cargo update

… serde_yaml serde_json serde regex ref-cast prost-build prost num-traits num-derive native-tls hyper flate2 cc backtrace anyhow Closes: #6675

Bumps [termcolor](https://github.com/BurntSushi/termcolor) from 1.1.0 to 1.1.2. - [Release notes](https://github.com/BurntSushi/termcolor/releases) - [Commits](BurntSushi/termcolor@1.1.0...1.1.2) Signed-off-by: dependabot[bot] <[email protected]> Closes: #6743

Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.20 to 0.3.21. - [Release notes](https://github.com/TeXitoi/structopt/releases) - [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) - [Commits](TeXitoi/structopt@v0.3.20...v0.3.21) Signed-off-by: dependabot[bot] <[email protected]> Closes: #6773

Closes: #6798

Closes: #6874

Bumps [regex](https://github.com/rust-lang/regex) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.4.2...1.4.3) Signed-off-by: dependabot[bot] <[email protected]> Closes: #7172

Add a lint enforcing that all unpublished dependencies not specify a version for first-party packages. Given that we will have a small subset of dependencies that will be initially published, this will reduce the effort needed to bump versions numbers when new versions of packages are published.

Support the terse format while listing tests, since that's what the test runner uses. Closes: #7932

The new test runner tries to list these out, and malfunctions because the full set of tests is printed out as both ignored and non-ignored tests.

Clean up references to Diem.

rexhoffman

Glad you kept the history, my suspicion is we're including this to be able to run some tests in x, but if we are not, this would be far better in a separate repo.

sunshowers · 2021-04-17T00:33:34Z

Glad you kept the history, my suspicion is we're including this to be able to run some tests in x, but if we are not, this would be far better in a separate repo.

Chatted about this with @rexhoffman -- would like to make it easy to add tighter integration between datatest-stable and this in the future, e.g. some of what's listed in #41.

We'd like to make this independent of the Diem repo, but it will still likely be tightly coupled with the test runner -- so move it into this repo.

bmwill and others added 30 commits September 21, 2019 23:15

Add generic descriptions, repositories, and homepages to Cargo.toml's

14c1ffa

Closes: #1194 Approved by: huitseeker

remove underscrores & dashes from descriptions

9262a91

Closes: #1194 Approved by: huitseeker

[lint] ensure all *.{rs,sh} files have a license header

dab1040

Closes: #1609 Approved by: davidiw

[language][Move] Added test framework

ebd4c38

- Added test framework for Move lang expected output tests - Added tests to check all of the stdlib files Closes: #1624 Approved by: vgao1996

[test] unblock the use of --ignored in libra-fuzzer

6549dd7

Closes: #3328 Approved by: bmwill

[test] explicitly and only state that these are no-op args/flags.

333f139

Closes: #3328 Approved by: bmwill

[deps] use cargo-edit's cargo upgrade command to cleanup project tomls

ea0ac8b

Closes: #4226 Approved by: metajack

fixup! [Deps] Downgrade bindgen to unyanked 0.54.0, upgrade others. c…

b4a1e85

…lang-sys 1.0.0/0.23.0 collision prevented bindgen upgrade Closes: #5762

[integer-overflow] enforce some checked operations

8dc0904

Closes: #6526

cargo upgrade --workspace aho-corasick anyhow backtrace bitvec cc cro…

fe84044

…ssbeam crossbeam-channel ctrlc env_logger indexmap indoc regex serde serde_derive serde_json structopt syn toml rayon serde-generate futures libc enum_dispatch syn handlebars bitvec memchr && cargo update

cargo upgrade --workspace aes-gcm ureq thiserror structopt sha2 sha-1…

b36eed6

… serde_yaml serde_json serde regex ref-cast prost-build prost num-traits num-derive native-tls hyper flate2 cc backtrace anyhow Closes: #6675

[Rename] Rename all occurences of "Libra" to "Diem"

a1f3d20

Closes: #6798

github url update, ignoring developers.libra.org

8941d00

Closes: #6874

sunshowers added 3 commits March 16, 2021 16:23

[datatest-stable] support --format terse

4dae209

Support the terse format while listing tests, since that's what the test runner uses. Closes: #7932

[datatest-stable] handle the --ignored flag

a309921

The new test runner tries to list these out, and malfunctions because the full set of tests is printed out as both ignored and non-ignored tests.

[datatest-stable] prepare for merge into diem-devtools

24a4a35

Clean up references to Diem.

sunshowers requested review from metajack, bmwill and rexhoffman March 26, 2021 01:13

rexhoffman approved these changes Mar 27, 2021

View reviewed changes

sunshowers added 2 commits April 16, 2021 17:34

[datatest-stable] merge into diem-devtools

5c53bbd

We'd like to make this independent of the Diem repo, but it will still likely be tightly coupled with the test runner -- so move it into this repo.

[datatest-stable] add to workspace

436a411

sunshowers merged commit 37f6fb1 into diem:main Apr 17, 2021

sunshowers deleted the datatest-move branch April 17, 2021 00:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move datatest-stable into this repository #35

move datatest-stable into this repository #35

sunshowers commented Mar 26, 2021 •

edited

Loading

rexhoffman left a comment •

edited

Loading

sunshowers commented Apr 17, 2021

move datatest-stable into this repository #35

move datatest-stable into this repository #35

Conversation

sunshowers commented Mar 26, 2021 • edited Loading

rexhoffman left a comment • edited Loading

Choose a reason for hiding this comment

sunshowers commented Apr 17, 2021

sunshowers commented Mar 26, 2021 •

edited

Loading

rexhoffman left a comment •

edited

Loading