Convert AnnotationList to playwright component test #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antti-manninen-vmv
force-pushed
the
fix/convert-annotation-list
branch
from
a35c213 to
7204f86
Compare
Chrysalis-B
reviewed
Jan 20, 2025
| @@ -57,18 +57,10 @@ test.describe('<AnnotationList />', () => { | |||
| scores: [_.pick(defaultScores, 'pregrading', 'answerId', 'questionId')] | |||
| } | |||
| const component = await mount(<AnnotationListStory results={resultsProps} />) | |||
There was a problem hiding this comment.
hmm, mä laittasin ehkä näihinkin esim. `component.getByRole('listitem').first().toHaveTextContent('Test pregrading annotation) tai siis että ei vertailtais tota innerHtml ollenkaan.
ja sitten noihin missä siellä ei saa olla mitään niin on varmaan joku expect....toBeEmpty() tai vastaava
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Käänsin yhden testin playwrightille. Snapshotit siirtyi suoraan itse testiin (mun suosikkitapa). Muuten aika pitkälti sama. Harmittavasti GH:n käli ei tunnista että tiedosto siirtyi vain