Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic writer #3

Merged
merged 10 commits into from
Dec 3, 2024
Merged

feat: add basic writer #3

merged 10 commits into from
Dec 3, 2024

Conversation

tomasciccola
Copy link
Contributor

@tomasciccola tomasciccola commented Sep 17, 2024 •
edited
Loading

should close #2

TODO:

@tomasciccola tomasciccola marked this pull request as draft September 17, 2024 15:37
@tomasciccola
Copy link
Contributor Author

I'll probably remove the current fixture and add a new one were the picture attachments are less weird

@EvanHahn
Mostly finish writer
08d71c4 
- Switch to `archiver` from `yazl` to create the ZIP files
- Basic tests for writer
- Clean up patch-package
- Improve types
@EvanHahn
Address all but one TODO
2a36954
@EvanHahn
Address last TODO
2815c33
@EvanHahn EvanHahn changed the title feat: add MLEFWriter feat: add basic MLEFWriter Dec 3, 2024
@EvanHahn EvanHahn changed the title feat: add basic MLEFWriter feat: add basic writer Dec 3, 2024
@EvanHahn EvanHahn marked this pull request as ready for review December 3, 2024 01:04
@EvanHahn EvanHahn merged commit 425092e into main Dec 3, 2024
1 check passed
@EvanHahn EvanHahn deleted the feat/writer branch December 3, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MLEFWriter
2 participants
@tomasciccola @EvanHahn