-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generate remoteDetectionAlert schema, chore: update @comapeo/schema to v1.1.1 #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works with remoteDetectionAlert
s. This script doesn't work for me:
import { generate } from './index.js'
console.log(generate('remoteDetectionAlert')[0])
I think we need to do a little extra to make this happen.
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@mapeo/mock-data", | |||
"version": "1.0.3-alpha.7", | |||
"version": "2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this instead be done in the release script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno know how this change slipped in there. Fixed on 700b27eca3ca348edf57b1895a3fafc696d2a3a9
I think this is not ready for review, but let me know if that's wrong. |
I think this may now be ready for review? |
Fixed in 03eb40c. Good to merge! |
ha! had the same non-fix ('cause I forgot to add |
No description provided.