Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate remoteDetectionAlert schema, chore: update @comapeo/schema to v1.1.1 #21

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

tomasciccola
Copy link
Contributor

No description provided.

@tomasciccola tomasciccola requested a review from EvanHahn October 2, 2024 17:48
Copy link
Contributor

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works with remoteDetectionAlerts. This script doesn't work for me:

import { generate } from './index.js'

console.log(generate('remoteDetectionAlert')[0])

I think we need to do a little extra to make this happen.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@mapeo/mock-data",
"version": "1.0.3-alpha.7",
"version": "2.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this instead be done in the release script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno know how this change slipped in there. Fixed on 700b27eca3ca348edf57b1895a3fafc696d2a3a9

@EvanHahn
Copy link
Contributor

EvanHahn commented Oct 3, 2024

I think this is not ready for review, but let me know if that's wrong.

@tomasciccola
Copy link
Contributor Author

I think this is not ready for review, but let me know if that's wrong.

I think this may now be ready for review?
We can now generate RemoteDetectionAlert docs. Its kind of weird how I solved the $ref to Geometry. I basically inline the schema by loading it manually and then resolve its definitions with dereference-json-schema. I still get a type error because we're deleting the $ref field which is a readonly string const. So if you have any ideas on how to avoid that (now there's a tsignore in there)...

@tomasciccola tomasciccola self-assigned this Oct 3, 2024
@tomasciccola tomasciccola changed the title chore: update @comapeo/schema to v1.1.0 chore: update @comapeo/schema to v1.1.1 Oct 3, 2024
@tomasciccola tomasciccola changed the title chore: update @comapeo/schema to v1.1.1 chroe: generate remoteDetectionAlert schema, chore: update @comapeo/schema to v1.1.1 Oct 9, 2024
@tomasciccola tomasciccola requested a review from EvanHahn October 9, 2024 19:18
@EvanHahn EvanHahn changed the title chroe: generate remoteDetectionAlert schema, chore: update @comapeo/schema to v1.1.1 chore: generate remoteDetectionAlert schema, chore: update @comapeo/schema to v1.1.1 Oct 9, 2024
@EvanHahn
Copy link
Contributor

EvanHahn commented Oct 9, 2024

Fixed in 03eb40c. Good to merge!

@tomasciccola
Copy link
Contributor Author

Fixed in 03eb40c. Good to merge!

ha! had the same non-fix ('cause I forgot to add $ref: Geometry.$id)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants