Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack to remove online dependencies for mapbox to fix #55. This:
config.json
including the default color.mapbox-gl-js
would not accept relative URLs, it requires a full URL.glyphs were tricky:
mapbox-gl-js
makes multiple requests as you move around the map for specific font stacks and ranges of glyphs. I get around this by parsing the style for all fonts, manually reviewing the network requests for what ranges are requested across the map (fragile!) and downloading all fonts for each range. The url for glyphs must include a {fontstack} tag, which we're ignoring since we've downloaded the entire fontstack and we're serving it as a static asset, so I just append it as a query string so the static server we're using in dev just ignores it.TODO: The folder structure I'm downloading to doesn't make sense, I think these scripts should probably live in mapfilter-desktop, but then we would need to figure out how to pass the style to mapfilter at runtime.