-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1880: Use flutter_html for all legal texts #1888
base: main
Are you sure you want to change the base?
Conversation
2b3c3b4
to
181ee09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some adjustments in the html template would make sense to me
E-Mail: <a href="mailto:[email protected]">[email protected]</a><br> | ||
Haftung im Sinne §§ 7 - 10 TMG</p> | ||
<p>Das Bayerische Staatsministerium für Arbeit und Soziales, Familie und Integration stellt sein App-Angebot unter folgenden Nutzungsbedingungen zur Verfügung:</p> | ||
<p>• Die App "Ehrenamtskarte" ist nach § 7 Abs. 1 TMG für die eigenen Inhalte, die es zur Nutzung bereithält, nach den allgemeinen Vorschriften verantwortlich. Die Haftung für Schäden materieller oder ideeller Art, die durch die Nutzung der Inhalte verursacht wurden, ist ausgeschlossen, sofern nicht Vorsatz oder grobe Fahrlässigkeit vorliegt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 i think, if we do here proper html we should have an unordered list with list item instead of p-tags starting with a bullet point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But i don't think we should put too much effort on disclaimer texts, even it would be nice if the html text styling would work (if we may also use it later for other issues)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, really 😐 one more iOS specific issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even styling doesn't work on ios properly. I'm okay with merging this since disclaimerTexts are not super important and everything is readable and links are clickable
Short description
Follow-up for #1881
I have changed other legal texts (copyright text, disclaimer text) to html to unify the approach.
Side effects
Not tested on iOS, but I believe it will look the same as the publisher text.
Testing
Check the copyright and disclaimer texts in the apps:
Über -> Lizenz
Über -> Haftung, Haftungsausschluss und Impressum
Resolved issues
N/a