Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1880: Use flutter_html for all legal texts #1888

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seluianova
Copy link
Contributor

Short description

Follow-up for #1881
I have changed other legal texts (copyright text, disclaimer text) to html to unify the approach.

Side effects

Not tested on iOS, but I believe it will look the same as the publisher text.

Testing

Check the copyright and disclaimer texts in the apps:
Über -> Lizenz
Über -> Haftung, Haftungsausschluss und Impressum

Resolved issues

N/a

@seluianova seluianova force-pushed the 1880-use-html-for-legal-texts branch from 2b3c3b4 to 181ee09 Compare January 30, 2025 15:27
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some adjustments in the html template would make sense to me

E-Mail: <a href="mailto:[email protected]">[email protected]</a><br>
Haftung im Sinne §§ 7 - 10 TMG</p>
<p>Das Bayerische Staatsministerium für Arbeit und Soziales, Familie und Integration stellt sein App-Angebot unter folgenden Nutzungsbedingungen zur Verfügung:</p>
<p>• Die App "Ehrenamtskarte" ist nach § 7 Abs. 1 TMG für die eigenen Inhalte, die es zur Nutzung bereithält, nach den allgemeinen Vorschriften verantwortlich. Die Haftung für Schäden materieller oder ideeller Art, die durch die Nutzung der Inhalte verursacht wurden, ist ausgeschlossen, sofern nicht Vorsatz oder grobe Fahrlässigkeit vorliegt.
Copy link
Contributor

@f1sh1918 f1sh1918 Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 i think, if we do here proper html we should have an unordered list with list item instead of p-tags starting with a bullet point

Copy link
Contributor Author

@seluianova seluianova Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that, but the padding annoyed me, when there is a large amount of text under one bullet item.
do you think it is fine like this?
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm i can not confirm any padding or margin working on ios
i used <ul> and inside <li> for testing
Only on paragraphs it seem to work for me

Currently it looks like this on ios (current state of your pr)

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But i don't think we should put too much effort on disclaimer texts, even it would be nice if the html text styling would work (if we may also use it later for other issues)

Copy link
Contributor Author

@seluianova seluianova Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, really 😐 one more iOS specific issue

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even styling doesn't work on ios properly. I'm okay with merging this since disclaimerTexts are not super important and everything is readable and links are clickable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants