-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contact creation in POI form #3196
base: develop
Are you sure you want to change the base?
Conversation
The new typescript file "contact_box.ts" needs to be added in "index.ts", otherwise it can't bring its effects 😿 |
Thank you for the hint! That would have been my question. |
@jarlhengstmengel |
9970b17
to
fa84fc1
Compare
dc6e504
to
8959822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot to the both of you!
This is a really good step forward. I have a few questions, but other than those it looks already very good :)
|
||
#: cms/templates/pois/poi_form_sidebar/related_contacts_box.html | ||
msgid "The new contact was successfully created." | ||
msgstr "Ein neuer Kontakt wurde erfolgreich erstellt." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Ein neuer Kontakt wurde erfolgreich erstellt." | |
msgstr "Der neue Kontakt wurde erfolgreich erstellt." |
This is very nit picky, but I think we should keep the definitive article to stay consistent to the English version, but yes, it doesn't sound as good
@@ -104,6 +104,8 @@ import "./js/menu"; | |||
import "./js/poi-categories/poicategory-colors-icons"; | |||
import "./js/dashboard/broken-links"; | |||
|
|||
import "./js/contact_box"; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% for contact in contacts %} | ||
<a href="{% url 'edit_contact' contact_id=contact.id region_slug=request.region.slug %}" | ||
class="block pt-2 hover:underline"> | ||
<i icon-name="pen-square" class="mr-2"></i> {{ contact.label_in_reference_list }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<i icon-name="pen-square" class="mr-2"></i> {{ contact.label_in_reference_list }} | |
<i icon-name="pencil" class="mr-2"></i> {{ contact.label_in_reference_list }} |
At least for the list views we changed the icon to the pencil, but maybe it's okay for this view because the context is slightly different? (And also: we still use this icon still in a few places)
Short description
This PR adds the creation of contacts with a collapsible box in the POI form.
Proposed changes
Side effects
Resolved issues
Fixes: #3088
Pull Request Review Guidelines