Support rrules with BYDAY frequencies
#3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-venhoff
force-pushed
the
bugfix/rrule_with_byday_frequency
branch
from
8e7f231 to
5be5d21
Compare
david-venhoff
force-pushed
the
bugfix/rrule_with_byday_frequency
branch
2 times, most recently
from
0066075 to
59aa0bd
Compare
Merged
MizukiTemma
added
blocker
MizukiTemma
requested review from
PeterNerlich,
jarlhengstmengel and
theresantonie
PeterNerlich
requested changes
Jan 10, 2025
There was a problem hiding this comment.
RRULE:FREQ=MONTHLY;UNTIL=20250502T220000Z;INTERVAL=1;BYMONTHDAY=3 still produces a ValueError('by_set_pos must not be None') (from outlook.calendar.txt in #3227)
Right now, we only support recurrence rules which can be also be created from within the recurrence rule form. However, this recurrence rule repeats every third day of the month, which cannot be expressed in the recurrence rule form (We only support monthly recurrences if we specify the nth-week and a weekday). So this error is intentional |
PeterNerlich
approved these changes
Jan 13, 2025
For example, `-1SU`. Unfortunately this commit contains a manual parsing implementation, because the `icalendar` package does not support these right now. (Though it will at the next update)
david-venhoff
force-pushed
the
bugfix/rrule_with_byday_frequency
branch
from
28ca313 to
94c01c4
Compare
charludo
pushed a commit
that referenced
this pull request
Jan 13, 2025
For example, `-1SU`. Unfortunately this commit contains a manual parsing implementation, because the `icalendar` package does not support these right now. (Though it will at the next update)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr is blocked because it depends on #3229, but it can already be reviewedThe blocker is now resolved
This pr adds support for importing events with rrules that contain
BYDAYentries with frequencies, for example-1SU(which means repeat every last Sunday).Unfortunately the icalendar library does not parse these entries fully right now, so this pr also implements some manual parsing. However, in its next major version icalendar will add support for that.
Proposed changes
BYDAYentry has a frequency, and use that frequency as a value forBYSETPOSBYDAYweekdaysSide effects
/
Resolved issues
Fixes: #3227
Pull Request Review Guidelines