Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when attempting to add inactive users to pages #3323

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jonbulz
Copy link
Contributor

@jonbulz jonbulz commented Jan 10, 2025

Short description

Show a more sensible error message when attempting to add inactive users to pages

Proposed changes

  • grant_permission method checks if user is active before checking the permissions

Side effects

None

Resolved issues

Fixes: #3078


Pull Request Review Guidelines

Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR and welcome (back) on board! 🚀
To me this looks good :)

@@ -10258,6 +10258,10 @@ msgid "An error has occurred. Please contact an administrator."
msgstr ""
"Ein Fehler ist aufgetreten. Bitte kontaktieren Sie eine:n Administrator:in."

#: cms/views/pages/page_permission_actions.py
msgid "Inactive users cannot be assigned to pages."
msgstr "Benutzer:innen können keiner Seite zugeordnet werden, solange ihr Nutzerkonto nicht aktiviert wurde."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Benutzer:innen können keiner Seite zugeordnet werden, solange ihr Nutzerkonto nicht aktiviert wurde."
msgstr "Benutzer:innen können keiner Seite zugeordnet werden, solange ihr Konto nicht aktiviert wurde."

Super nit pick: I think we usually use the gender neutral version and just say "Konto"

Copy link
Contributor

@jarlhengstmengel jarlhengstmengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a new message when an inactive user is added to a page
3 participants