LUN-132: Favorites #307
Merged
LUN-132: Favorites #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
ztefanie,
sarahsporck and
f1sh1918
as code owners
steffenkleinle
commented
May 30, 2022
ztefanie
reviewed
May 31, 2022
| @@ -107,15 +100,13 @@ const AudioPlayer = ({ document, disabled, submittedAlternative }: AudioPlayerPr | |||
| } | |||
|
|
|||
| return ( | |||
| <StyledView> | |||
There was a problem hiding this comment.
I think this broke styling, button is not in the middle any more.
|
Tested on Android emulator works like a charm. 👍 |
|
Please also add a release note |
# Conflicts: # src/components/VocabularyList.tsx # src/components/VocabularyListItem.tsx # src/constants/labels.json # src/routes/VocabularyDetailScreen.tsx # src/routes/VocabularyListScreen.tsx # src/routes/choice-exercises/__tests__/ArticleChoiceExerciseScreen.spec.tsx # src/routes/write-exercise/components/InteractionSection.tsx
f1sh1918
reviewed
Jun 3, 2022
LUN-132: Change FavoriteButton
# Conflicts: # src/constants/endpoints.ts # src/routes/write-exercise/components/__tests__/InteractionSection.spec.tsx
ztefanie
approved these changes
Jun 13, 2022
Steffen said we can merge it for him when everything is resolved. Favs in the bottom bar is enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword LUN.
Hopefully my final favorites PR 🎉