Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add professions in the vocabulary overview #513

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Add professions in the vocabulary overview #513

merged 1 commit into from
Feb 17, 2024

Conversation

MizukiTemma
Copy link
Member

Short description

This PR adds professions related to each word in the vocabulary overview

Proposed changes

  • Add related professions in the vocabulary overview

Resolved issues

Fixes: #267

@MizukiTemma MizukiTemma requested a review from a team as a code owner February 10, 2024 17:30
JoeyStk
JoeyStk approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and looks good! I only have one small code style comment, but it's really just a suggestion, so please also feel free to reject it! 😃

lunes_cms/cms/admins/document_admin.py Show resolved Hide resolved
@MizukiTemma MizukiTemma merged commit fb65431 into develop Feb 17, 2024
1 check passed
@MizukiTemma MizukiTemma deleted the profession_in_vocabulary_overview branch February 17, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeyStk JoeyStk JoeyStk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profession in vocabulary overview
2 participants
@MizukiTemma @JoeyStk