Merge develop into master #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new bin, both at the web UI and further down the stack.
… to throw an exception in addition to an error message for humans. This is a risky move up the stack I might think, if it is not caught under normal operations.
… to throw an exception in addition to an error message for humans. This is a risky move up the stack I might think, if it is not caught under normal operations.
…com/xmacex/dmi-tcat into phrases_must_not_exceed_60chrs_each
… procrastination commit under cognitive stress of getting all the tests in place. Please bear with me.
…ctionality in modify_bin() too. On the UI side the same validateQuery() is used as when making a new bin, so I that should be fine.
…0chrs limit on phrases.
…ing on a more substantial task of adding tests in TDD style. Feedback provided by PHP Code Sniffer with default settings.
… is not an OOP project.
…ong because there is too much whitespace in the middle of it.
… 60 characters long, even some weird ones.
…m locally though, but not committing.
…e format familiar from the Twitter UI with disjunctions marked by ' OR ' instead of the comma ',' as the query bin manager thing on TCAT. Updated tests pass (hmm how can I have a test suite that I can commit to, but that does not get pushed to the repo? Maybe a separate project outside of the dmi-tcat top directory or something. Anyway...).
Sometimes deleting large query bins can fail or timeout, removing the tweet tables but not the entry from the bins table. This results in the app crashing when accessing the capture page. This change attempts to prevent this by a) putting deletion operations in a single transaction and b) catching errors when retrieving bin info. The latter change is required because MySQL does not do schema changes such as table deletion in transactions so the problem with incomplete bin removal can still occur.
Attempt to make bin removal and info lookup more robust.
Consider all DB-collations beginning w/ 'utf8mb4' to be utf8mb4 collations
Removed recursive call to search
Phrases must not exceed 60chrs each
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains:
#335
#389
#343
#402