-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Spaces Key API #1309
base: main
Are you sure you want to change the base?
Support Spaces Key API #1309
Conversation
8c45dad
to
bb5af54
Compare
186198b
to
ad1edb3
Compare
ad1edb3
to
025fc5c
Compare
279d6d4
to
e7b469c
Compare
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource" | ||
) | ||
|
||
func TestAccDigitalOceanSpacesKey_basic(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these test are failing for me with 403s. If I update the names of the buckets with ones that already exist on my account, then they pass. We need to create the buckets used in the test as part of the configs. Take a look at the existing tests for Spaces buckets for examples, e.g.:
terraform-provider-digitalocean/digitalocean/spaces/resource_spaces_bucket_test.go
Lines 631 to 639 in 4ec164a
func testAccDigitalOceanBucketConfig(name string) string { | |
return fmt.Sprintf(` | |
resource "digitalocean_spaces_bucket" "bucket" { | |
name = "%s" | |
acl = "public-read" | |
region = "ams3" | |
} | |
`, name) | |
} |
The tests can be run with: make testacc TESTARGS='-run=TestAccDigitalOceanSpacesKey'
d5401a5
to
cc7d2d9
Compare
cc7d2d9
to
8e33402
Compare
Adds support for Spaces Key API based on digitalocean/openapi#958