Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Spaces Key API #1309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lee-aaron
Copy link
Contributor

Adds support for Spaces Key API based on digitalocean/openapi#958

@lee-aaron lee-aaron force-pushed the support-Spaces-API branch 2 times, most recently from 8c45dad to bb5af54 Compare January 22, 2025 20:01
@lee-aaron lee-aaron force-pushed the support-Spaces-API branch 8 times, most recently from 186198b to ad1edb3 Compare January 23, 2025 17:08
@lee-aaron lee-aaron force-pushed the support-Spaces-API branch 2 times, most recently from 279d6d4 to e7b469c Compare January 23, 2025 19:20
@andrewsomething andrewsomething self-assigned this Jan 28, 2025
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
)

func TestAccDigitalOceanSpacesKey_basic(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these test are failing for me with 403s. If I update the names of the buckets with ones that already exist on my account, then they pass. We need to create the buckets used in the test as part of the configs. Take a look at the existing tests for Spaces buckets for examples, e.g.:

func testAccDigitalOceanBucketConfig(name string) string {
return fmt.Sprintf(`
resource "digitalocean_spaces_bucket" "bucket" {
name = "%s"
acl = "public-read"
region = "ams3"
}
`, name)
}

The tests can be run with: make testacc TESTARGS='-run=TestAccDigitalOceanSpacesKey'

@lee-aaron lee-aaron force-pushed the support-Spaces-API branch 3 times, most recently from d5401a5 to cc7d2d9 Compare February 20, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants