fix(button): rename 'small' variant to 'normal' #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button size that was previously named 'small' actually is more like the 'normal' size variant in PrimeVue. For this reason we decided to: - Change the default button size from 'small' to 'normal' - Change all styling that was previously applied for 'small' to be applied for 'normal' instead - Drop the 'small' variant as we don't have designs for that yet This leaves the option open to introduce a smaller button variant in the future.
|
Closing this as it's already been merged but GitHub somehow didn't detect it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button size that was previously named 'small' actually is more like the 'normal' size variant in PrimeVue. For this reason we decided to:
This leaves the option open to introduce a smaller button variant in the future.