Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Norms text utils #37

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Norms text utils #37

merged 4 commits into from
Oct 17, 2024

Conversation

andreasphil
Copy link
Member

This PR adds two text-related components from Norms:

  • A label with a value which can be copied by clicking the label
  • A text container that can be limited to a certain number of lines, after which it will show an expand/collapse control

It also sets up Vue Testing Library for unit testing those components.

MasterCarl
MasterCarl approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@MasterCarl MasterCarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supplying these components! Apart from the two suggestions/questions, it looks good to me.

src/components/RisCopyableLabel/RisCopyableLabel.stories.ts Show resolved Hide resolved
src/components/RisCopyableLabel/RisCopyableLabel.vue Show resolved Hide resolved
@andreasphil andreasphil merged commit 03fa2c3 into main Oct 17, 2024
3 checks passed
@andreasphil andreasphil deleted the norms-text-utils branch October 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterCarl MasterCarl MasterCarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreasphil @MasterCarl