Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to short relationships last in OperationDefinition #2385

Merged
merged 9 commits into from
Nov 16, 2024

Conversation

deathemperor
Copy link
Contributor

@deathemperor deathemperor commented Jun 14, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes #2235

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

I've been running this on our development code base

Test Environment:

  • OS: MacOS 15
  • "@graphql-eslint/eslint-plugin": "^3.20.1",
  • NodeJS: 21.5.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: dfec4ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-eslint/eslint-plugin

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@deathemperor deathemperor marked this pull request as ready for review June 14, 2024 07:17
@deathemperor
Copy link
Contributor Author

@dimaMachina would you please review? thanks.

Copy link
Owner

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase and add new groups option, similar as in PR

@dimaMachina dimaMachina merged commit afa8b8a into dimaMachina:master Nov 16, 2024
7 checks passed
@deathemperor
Copy link
Contributor Author

thanks for the code rework @dimaMachina

@dimaMachina
Copy link
Owner

Thanks for contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to sort nodes last in group
2 participants