Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS and libs upgrades #22

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

OS and libs upgrades #22

wants to merge 1 commit into from

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Jul 11, 2024

I will get these tested once merged.

zandre-eng
zandre-eng previously approved these changes Jul 11, 2024
Copy link
Collaborator

@zandre-eng zandre-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to test the compileSdk version once merged. I believe we did have some issues in the past where the Tech5 libraries weren't happy when we fiddled with the version.

@shubham1g5
Copy link
Contributor Author

I believe we did have some issues in the past where the Tech5 libraries weren't happy when we fiddled with the version.

That's great to know, thanks!

Base automatically changed from ci_setup to master July 11, 2024 11:22
@shubham1g5 shubham1g5 dismissed zandre-eng’s stale review July 11, 2024 11:22

The base branch was changed.

Copy link
Contributor

@avazirna avazirna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only note is to make sure this gets tested on at least 2 devices from different brands. We have in the past faced issues with the app completely crashing in same devices models, which only got resolved after combining different versions of the libraries from sample apps they shared with us.

@shubham1g5 shubham1g5 marked this pull request as draft July 11, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants