Show payment metrics #405
Open
Show payment metrics #405
+239
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calellowitz
requested changes
Oct 3, 2024
calellowitz
requested changes
Oct 4, 2024
| for payment in payments: | ||
| paid += payment.amount | ||
|
|
||
| while paid > current_work.payment_accrued: |
There was a problem hiding this comment.
This is missing the logic deducts from the total paid when we assign that payment to a completed work. Right now this will run forever in most cases, because the total paid out is always greater than what is due for the next completed work. For example if each work accrues $5 and the first payment was $10, 10 is always greater than 5. We need to deduct what we are assigning to the work, or keep a similar running total for what we owe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dimagi.atlassian.net/browse/CCCT-493