Use defaults with getattr rather than in settings

This avoids polluting settings.py with default values that a user will likely never actually need to tweak.
dimagi · Aug 16, 2024 · 52d49d8 · 52d49d8
1 parent d7b58f5
commit 52d49d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/corehq/motech/repeaters/const.py b/corehq/motech/repeaters/const.py
@@ -7,8 +7,8 @@
 MAX_RETRY_WAIT = timedelta(days=7)
 MIN_RETRY_WAIT = timedelta(minutes=60)
 RATE_LIMITER_DELAY_RANGE = (
-    timedelta(minutes=settings.MIN_REPEATER_RATE_LIMIT_DELAY),
-    timedelta(minutes=settings.MAX_REPEATER_RATE_LIMIT_DELAY),
+    timedelta(minutes=getattr(settings, 'MIN_REPEATER_RATE_LIMIT_DELAY', 0)),
+    timedelta(minutes=getattr(settings, 'MAX_REPEATER_RATE_LIMIT_DELAY', 15)),
 )
 CHECK_REPEATERS_INTERVAL = timedelta(minutes=5)
 CHECK_REPEATERS_PARTITION_COUNT = settings.CHECK_REPEATERS_PARTITION_COUNT

diff --git a/settings.py b/settings.py
@@ -847,9 +847,6 @@
 # how many tasks to split the check_repeaters process into
 CHECK_REPEATERS_PARTITION_COUNT = 1
 
-MIN_REPEATER_RATE_LIMIT_DELAY = 0  # minutes
-MAX_REPEATER_RATE_LIMIT_DELAY = 15  # minutes
-
 # If ENABLE_PRELOGIN_SITE is set to true, redirect to Dimagi.com urls
 ENABLE_PRELOGIN_SITE = False