Merge pull request #35316 from dimagi/jt/filename_broadcast_repeat_bug

Filename Broadcast in Repeat Group Bug
dimagi · Nov 1, 2024 · 6deb5c2 · 6deb5c2
2 parents 97072ef + 85359fe
commit 6deb5c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/corehq/apps/cloudcare/static/cloudcare/js/form_entry/const.js b/corehq/apps/cloudcare/static/cloudcare/js/form_entry/const.js
@@ -4,6 +4,7 @@ hqDefine("cloudcare/js/form_entry/const", [], function () {
         GROUP_TYPE: 'sub-group',
         QUESTION_TYPE: 'question',
         GROUPED_ELEMENT_TILE_ROW_TYPE: 'grouped-element-tile-row',
+        BROADCAST_FIELD_FILENAME: 'filename',
 
         // Entry types
         STRING: 'str',

diff --git a/corehq/apps/cloudcare/static/cloudcare/js/form_entry/entries.js b/corehq/apps/cloudcare/static/cloudcare/js/form_entry/entries.js
@@ -198,8 +198,7 @@ hqDefine("cloudcare/js/form_entry/entries", [
                 var receiveTopic = match[1];
                 var receiveTopicField = match[2];
                 if (receiveTopicField === constants.RECEIVER_FIELD_INDEXED) {
-                    var ixMatch = question.ix().match(/_(\d+)/g);
-                    receiveTopicField = ixMatch ? ixMatch.pop().replace('_', '') : '0';
+                    receiveTopicField = constants.BROADCAST_FIELD_FILENAME;
                 }
                 question.broadcastPubSub.subscribe(function (message) {
                     if (message === constants.NO_ANSWER) {
@@ -993,8 +992,8 @@ hqDefine("cloudcare/js/form_entry/entries", [
             self.question.onchange();
 
             if (self.broadcastTopics.length) {
-                // allow support for broadcasting multiple filenames
-                var broadcastObj = Object.fromEntries([self.file()].map((file, i) => [i, file.name]));
+                var broadcastObj = {};
+                broadcastObj[constants.BROADCAST_FIELD_FILENAME] = self.file().name;
                 self.question.formplayerMediaRequest.then(function () {
                     self.broadcastMessages(self.question, broadcastObj);
                 });