show alert banner for release errors

dimagi · Oct 31, 2024 · e32adc0 · e32adc0
1 parent a430948
commit e32adc0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/corehq/apps/app_manager/static/app_manager/js/releases/releases.js b/corehq/apps/app_manager/static/app_manager/js/releases/releases.js
@@ -243,6 +243,7 @@ hqDefine('app_manager/js/releases/releases', function () {
         self.buildState = ko.observable('');
         self.buildErrorCode = ko.observable('');
         self.errorMessage = ko.observable(self.genericErrorMessage);
+        self.releaseErrorMessage = ko.observable();
         self.onlyShowReleased = ko.observable(false);
         self.fetchState = ko.observable('');
         self.fetchLimit = ko.observable();
@@ -387,6 +388,7 @@ hqDefine('app_manager/js/releases/releases', function () {
         };
 
         self.toggleRelease = function (savedApp, event) {
+            self.releaseErrorMessage(null);
             $(event.currentTarget).parent().prev('.js-release-waiting').removeClass('hide');
             var isReleased = savedApp.is_released();
             var savedAppId = savedApp.id();
@@ -404,7 +406,7 @@ hqDefine('app_manager/js/releases/releases', function () {
                     },
                     success: function (data) {
                         if (data.error) {
-                            alert(data.error);
+                            self.releaseErrorMessage(data.error);
                             $(event.currentTarget).parent().prev('.js-release-waiting').addClass('hide');
                             savedApp.is_released(isReleased);
                         } else {
@@ -492,6 +494,7 @@ hqDefine('app_manager/js/releases/releases', function () {
         self.actuallyMakeBuild = function () {
             self.buildState('pending');
             self.errorMessage(self.genericErrorMessage);
+            self.releaseErrorMessage(null);
             $.post({
                 url: self.reverse('save_copy'),
                 success: function (data) {

diff --git a/corehq/apps/app_manager/templates/app_manager/partials/releases/releases_table.html b/corehq/apps/app_manager/templates/app_manager/partials/releases/releases_table.html
@@ -97,6 +97,8 @@
     <span data-bind="visible: buildErrorCode() !== 403, text: errorMessage">
     </span>
   </div>
+  <div class="alert alert-danger" data-bind="html: releaseErrorMessage, visible: releaseErrorMessage">
+  </div>
 
   <h4 id="loading" class="hide"
       data-bind="visible: showLoadingSpinner(), css: {hide: false}">