Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enterprise dashboard improvements toggle #35531

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jingcheng16
Copy link
Contributor

@jingcheng16 jingcheng16 commented Dec 17, 2024

Product Description

Technical Summary

Ticket: https://dimagi.atlassian.net/browse/SAAS-16377
We hide Security Center page when this page doesn't have any tile.
Since Two Factor Authentication Tile is now developed, we should remove the toggle to release the page and the tile.

Feature Flag

Safety Assurance

Safety story

Verified locally and on staging

Automated test coverage

QA Plan

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@jingcheng16 jingcheng16 added the product/all-users-all-environments Change impacts all users on all environments label Dec 17, 2024
@jingcheng16 jingcheng16 marked this pull request as ready for review December 17, 2024 18:07
Copy link

sentry-io bot commented Dec 17, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: corehq/tabs/tabclasses.py

Function Unhandled Issue
sidebar_items NameError: name 'ConnectMesssagingUserView' is not defined /a/{domain}/messaging/...
Event Count: 28
sidebar_items NameError: name 'ConnectMesssagingUserView' is not defined /a/{domain}/messaging/co...
Event Count: 5
sidebar_items NameError: name 'ConnectMesssagingUserView' is not defined /a/{domain}/messaging/b...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@jingcheng16 jingcheng16 merged commit 4e7214f into master Dec 18, 2024
13 checks passed
@jingcheng16 jingcheng16 deleted the jc/remove-enterprise-console-ff branch December 18, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants